Add Columns to utilize Sections (tables) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kdaisho
commented
Jul 7, 2023
| <Text style={footer}>Airbnb, Inc., 888 Brannan St, San Francisco, CA 94103</Text> | ||
| <Link href="https://airbnb.com" style={reportLink}>Report unsafe behavior</Link> | ||
| </Container> | ||
| <Column> |
There was a problem hiding this comment.
It looks like I've changed a lot, but most of them are due to new indentations. What I actually did is adding <Column> after <Section>
| 2125 Chestnut St | ||
| <br /> | ||
| San Francisco, CA 94123 | ||
| <Column> |
There was a problem hiding this comment.
The same goes here. All these new lines are caused by increased indentations. What I did is wrapping things with <Column>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove empty tables from the email examples, specifically the Airbnb Review Notification and Apple Receipt templates.
Through my investigation, I discovered that the
Sectioncomponent's opening tag must be followed by theColumncomponent, which renders the<td>tag. If this sequence is not maintained, theSectioncomponents can result in empty tables throughout the templates, causing components that should be wrapped by tables to appear on their own.