Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Packaging to get rid of warning in Sveltekit 2 #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bertybot
Copy link

Description

This package is using an old pattern of packaging Svelte components that causes error with the newest version of the Svelte Vite plugin used in Sveltekit 2

image

Changes

  • Updated to latest version of @sveltejs/package
  • Implemented recommendations from @sveltejs/package
    • Files are now served from /dist
    • exports fields added
  • Added publint to lint package and fixed linting errors
    • sveltekit is now correctly flagged as a peerDependency

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 2:45pm

@n00ki
Copy link

n00ki commented Feb 4, 2024

@carstenlebek could this PR get merged?

@NickAnthony
Copy link

@carstenlebek friendly bump

@@ -8,3 +8,4 @@ node_modules
!.env.example
vite.config.js.timestamp-*
vite.config.ts.timestamp-*
dist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: No NL at EOF

@polaroi8d
Copy link

Any chance to merge this and create a release, or @carstenlebek, could you add me as a contributor to do it? It’s really good work, but we need to keep the project going.

@SonnyFishback
Copy link

LGTM @carstenlebek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants