feat: fix the bug that matchingForGFunction and matchingDomainForGFunction can affect the logic of role matching and domain matching
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for casbin-editor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hsluoyz
changed the title
matchingForGFunction and matchingDomainForGFunction can affect the logic of role matching and domain matching
|
🎉 This PR is included in version 1.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #184
Reason
matchingForGFunctionandmatchingDomainForGFunctioncan affect the logic of role matching and domain matching, potentially leading to results that do not align with expectations.Resolve
matchingForGFunctionandmatchingDomainForGFunction.