feat: add optional AxiosRequestConfig parameter in constructor, add /introspect endpoint #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @imp2002 please review |
|
@cidrmill add the new usage to README as a comment: https://github.com/casdoor/casdoor-nodejs-sdk?tab=readme-ov-file#step1-init-sdk
|
cidrmill
changed the title
hsluoyz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into issues with this library's use of Axios and the intranet self-signed enterprise certificate on the Casdoor instance. Calls to
SDK.getAuthToken(code)would be met with:A solution is to provide an instance of
https.Agent({ ca: string })with the AxiosRequestConfig when creating the Axios instance. This wasn't possible as there was no exposed method to add a custom AxiosRequestConfig with creating a new SDK() instance.I added an optional param
axiosConfig?: AxiosRequestConfigto theSDKconstruction which is passed withnew Request(...).