Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove extra '}' typo in get profile URL APIs #62

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

elierotenberg
Copy link
Contributor

  • Remove } typo in generated user profile urls
  • Make accessToken explicitly optional, reflecting the actual runtime behavior (typings only, no runtime changes).

* Remove `}` typo in generated user profile urls
* Make accessToken explicitly optional, reflecting
  the actual runtime behavior (typings only, no
  runtime changes).
@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@hsluoyz hsluoyz mentioned this pull request Jun 6, 2024
@hsluoyz hsluoyz changed the title fix: user profile extra '}', optional accessToken fix: remove extra '}' typo in get profile URL APIs Jun 6, 2024
@hsluoyz hsluoyz changed the title fix: remove extra '}' typo in get profile URL APIs feat: remove extra '}' typo in get profile URL APIs Jun 6, 2024
@hsluoyz hsluoyz merged commit ac29cfd into casdoor:master Jun 6, 2024
6 checks passed
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@elierotenberg elierotenberg deleted the fix-get-user-profile-url branch June 7, 2024 09:50
elierotenberg added a commit to elierotenberg/casdoor-nodejs-sdk that referenced this pull request Jun 7, 2024
hsluoyz pushed a commit that referenced this pull request Jun 7, 2024
* chore: make profileUrl accessToken optional in SDK

* Propagates changes from #62

* fix: extra `}` at the end of getSignUpUrl

* Similar to 62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants