Use a dummy output to block concurrency

cashapp · Nov 5, 2024 · fbd1517 · fbd1517
1 parent 38f95b2
commit fbd1517
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/misk-admin/build.gradle.kts b/misk-admin/build.gradle.kts
@@ -165,6 +165,12 @@ val buildMiskWeb = tasks.register("buildMiskWeb", MiskWebBuildTask::class.java)
   rootDir.set(project.rootDir)
   inputFiles.setFrom(inputs)
   outputFiles.setFrom(outputs)
+
+  // misk-admin:web-actions:build uses a different version of node compared to
+  // misk-admin:buildMiskWeb, and running them concurrently may result in weird
+  // errors. Adding this dummy output ensures tasks that share this output do
+  // not run concurrently.
+  this.outputs.dir(rootProject.layout.buildDirectory.dir("node.concurrency-blocker.dummy"))
 }
 
 // buildMiskWeb is expensive and generally not needed locally. Only build it on CI, or if
@@ -183,10 +189,6 @@ tasks.register<Copy>("buildAndCopyWebActions") {
   })
   into(project.layout.buildDirectory.dir("resources/main/web/_tab/web-actions-v4"))
   dependsOn(":misk-admin:web-actions:build")
-  // misk-admin:web-actions:build uses a different version of node compared to
-  // misk-admin:buildMiskWeb, and running them concurrently may result in weird
-  // errors.
-  mustRunAfter("buildMiskWeb")
 }
 
 sourceSets {

diff --git a/misk-admin/web-actions/build.gradle.kts b/misk-admin/web-actions/build.gradle.kts
@@ -28,6 +28,12 @@ tasks.register<MiskConsoleBuildTask>("build") {
   )
 
   outputFiles.setFrom(projectDir.resolve("lib"))
+
+  // misk-admin:web-actions:build uses a different version of node compared to
+  // misk-admin:buildMiskWeb, and running them concurrently may result in weird
+  // errors. Adding this dummy output ensures tasks that share this output do
+  // not run concurrently.
+  this.outputs.dir(rootProject.layout.buildDirectory.dir("node.concurrency-blocker.dummy"))
 }
 
 @CacheableTask