Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] solving the mambaforge miniforge depreciation in the quick_install #171

Open
wants to merge 2 commits into
base: rubicon
Choose a base branch
from

Conversation

gordonkoehn
Copy link
Contributor

@gordonkoehn gordonkoehn self-assigned this Jan 27, 2025
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH shellcheck 13 0 1.22s
✅ DOCKERFILE hadolint 1 0 0.32s
✅ JUPYTER jupyfmt 12 9 0 8.43s
✅ MARKDOWN markdownlint 17 3 0 2.26s
✅ PERL perlcritic 1 0 1.81s
✅ PYTHON black 53 1 0 2.62s
✅ SNAKEMAKE snakefmt 25 2 0 11.07s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@gordonkoehn gordonkoehn requested a review from DrYak January 27, 2025 07:50
@gordonkoehn gordonkoehn marked this pull request as ready for review January 27, 2025 07:50
@gordonkoehn
Copy link
Contributor Author

gordonkoehn commented Jan 27, 2025

@DrYak

I've tried to fix the installer issue #170; it seemed isolated enough for me to take on.

What do you think? Do you think this will work?

Miniforge seems to have changed the installer names with the depreciation of mambaforge.

Some of the above tests are failing, but I am unsure which test to look for, i.e. which uses the ./utils/quick_installe.sh.
It works on my machine now.

Which tests are currently broken? Could you please review this?

Also, I am not sure what the best practice is here; as fixing this seems rather urgent, do we merge to rubicon or main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant