-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mzonder endpoints #1911
base: main
Are you sure you want to change the base?
add mzonder endpoints #1911
Conversation
WalkthroughThis pull request updates the Celestia documentation for both the Mainnet Beta and Mocha testnet by adding several new community endpoints. The changes include new RPC, API, gRPC, and WebSocket endpoints, along with additional Data Availability node entries specifying their respective port configurations. These updates enhance the documentation by providing users with more options for connecting to the Celestia network. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
how-to-guides/mainnet.md (2)
178-178
: New API Endpoint with Explicit PortThe new API endpoint
api-celestia.mzonder.com:443
has been introduced. Note that in the same list there is also an entryapi-celestia.mzonder.com
without the port. Please verify if both entries are necessary or if they should be consolidated for clarity and consistency.
280-283
: New Full-Storage DA Endpoint AdditionThe addition of the full-storage DA endpoint:
- Endpoint:
celestia-da-full-storage.mzonder.com
- RPC Port: 27758
- Gateway Port: 27759
is a valuable expansion to the node options. It would be helpful to confirm that the distinction between this full-storage node and the archive endpoint (added above) is clear to users—both in terms of functionality and intended usage. Consider adding a brief note in the documentation if further clarification is needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
how-to-guides/mainnet.md
(6 hunks)
🔇 Additional comments (4)
how-to-guides/mainnet.md (4)
156-157
: New RPC Endpoint Addition for Community Consensus NodesThe addition of the RPC endpoint
rpc-celestia.mzonder.com:443
is formatted consistently with the other entries in this section. Please confirm that this endpoint has been tested in production-like scenarios to ensure proper connectivity and TLS configuration when using port 443.
199-199
: New gRPC Endpoint AdditionThe gRPC endpoint
grpc-celestia.mzonder.com:443
has been added. Its format is consistent with other gRPC endpoints. Verify that the endpoint’s configuration (including the port) aligns with your service setup and that it adheres to the network’s security requirements.
208-208
: New WebSocket Endpoint AdditionThe WebSocket endpoint
wss://rpc-celestia.mzonder.com:443/websocket
is now part of the community WebSocket endpoints. Its use of the secure WebSocket protocol (wss://) is in line with best practices. Please ensure that the backend service correctly supports WebSocket connections on this endpoint.
262-264
: Data Availability Archival Endpoint AdditionA new Data Availability (DA) RPC endpoint for archive nodes has been added:
- Endpoint:
celestia-archive-rpc.mzonder.com
- gRPC Port: 9090
- RPC Port: 26657
This configuration is consistent with existing DA endpoints. Please verify that these port assignments and the endpoint semantics align with the network specifications and that documentation elsewhere clearly explains the role of this archive endpoint.
Overview
Summary by CodeRabbit