feat: update _parseListType (#229)

* feat: update _parseListType * refactor: move directive check to parse method
ceramicstudio · Jul 26, 2024 · 941a947 · 941a947
1 parent 7b5e5c3
commit 941a947
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -0,0 +1,5 @@
+{
+    "cSpell.words": [
+        "undeployed"
+    ]
+}
diff --git a/packages/devtools/src/schema/parser.ts b/packages/devtools/src/schema/parser.ts
@@ -521,6 +521,7 @@ export class SchemaParser {
     hasCreateModel: boolean,
   ): DefinitionWithReferences<ListFieldDefinition> {
     const list = directives.find((d) => d.name === 'list')
+    const immutable = directives.some((item) => item.name === 'immutable')
     if (list == null) {
       throw new Error(`Missing @list directive on list field ${fieldName} of object ${objectName}`)
     }
@@ -534,6 +535,7 @@ export class SchemaParser {
     const definition: ListFieldDefinition = {
       type: 'list',
       required,
+      immutable,
       item: item.definition,
       maxLength: list.args.maxLength as number,
     }

diff --git a/packages/devtools/test/schema.test.ts b/packages/devtools/test/schema.test.ts
@@ -795,6 +795,7 @@ describe('schema parsing and compilation', () => {
       ) {
         uniqueValue: Int @immutable
         tag: String! @string(minLength: 1, maxLength: 100)
+        uniqueListValue: [Int] @list(maxLength: 5) @immutable
       }
       `),
     ).toMatchObject({
@@ -803,7 +804,7 @@ describe('schema parsing and compilation', () => {
           action: 'create',
           model: {
             name: 'ModelWithImmutableProp',
-            immutableFields: ['uniqueValue'],
+            immutableFields: ['uniqueValue', 'uniqueListValue'],
             accountRelation: { type: 'single' },
             description: 'Test model with an immutable int property',
             schema: {