You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following support for optional relations in Ceramic, this PR allows setting optional fields to null in the GraphQL updates and apply logic to remove these fields for the JSON patch.
Opening as draft as the Ceramic dependencies will need to change from RC to stable versions, but should be OK to review already.
LGTM! Do you think that following this PR I should include a test case in #205 where an immutable field its updated to a null value?
Thanks!
I think if we implement the change that the update mutation object doesn't include immutable fields, it shouldn't even possible to set the fields to null using the ComposeDB APIs, would it?
LGTM! Do you think that following this PR I should include a test case in #205 where an immutable field its updated to a null value?
Thanks! I think if we implement the change that the update mutation object doesn't include immutable fields, it shouldn't even possible to set the fields to null using the ComposeDB APIs, would it?
No, you are right, just checking in case I was missing something
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following support for optional relations in Ceramic, this PR allows setting optional fields to
nullin the GraphQL updates and apply logic to remove these fields for the JSON patch.Opening as draft as the Ceramic dependencies will need to change from RC to stable versions, but should be OK to review already.