Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAP-1612 bug fixes #567

Merged
merged 3 commits into from
Dec 17, 2024
Merged

DATAP-1612 bug fixes #567

merged 3 commits into from
Dec 17, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Dec 17, 2024

Various bug fixes:

  • Tour button styling updated to reflect design system
  • Pagination button styling updated to reflect design system
  • Removed spacing between text and icon for "Show More" and "Show Less" buttons in Trends panel

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 December 17, 2024 22:29
flacoman91
flacoman91 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@flacoman91 flacoman91 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 69bfab5 Dec 17, 2024
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1612-Bug-Fixes branch December 17, 2024 22:43
flacoman91 pushed a commit that referenced this pull request Dec 17, 2024
@cdmh219 @flacoman91
DATAP-1612 bug fixes (#567)
264c3db 
* updated styling for Tour Button

* removed spacing between Show More/Less button text and icon

* updated pagination buttons to use latest styling from design system

---------

Co-authored-by: Chanel Henley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flacoman91 flacoman91 flacoman91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmh219 @flacoman91