DATAP-1621 - adding suggest typeahead and sub-agg search for product and issue #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update test coverage
flacoman91
force-pushed
the
DATAP-1621-product-search-bar
branch
from
004bf5c to
8172430
Compare
…-ui into DATAP-1621-product-search-bar
fix cypress test adjust and make maxResults 5 update dist
flacoman91
force-pushed
the
DATAP-1621-product-search-bar
branch
from
110c53a to
6641564
Compare
|
This looks good to me , but I can't approve my own PRs. 
|
cdmh219
approved these changes
Jan 8, 2025
|
The styling looks good to me (ultimately I wasn't happy with any of the alternative variations I explored), but the search results look to be showing only sub-filter results, even when parent filter items match the search. In Complaint Explorer, both are returned, so that if someone searches and realizes what they want is a parent filter item, they can select it from the search results. For example, "managing an account" and "closing an account" should both appear in the search results for "account" as their own selectable items the way they do in Complaint Explorer, but I scrolled through the whole list and didn't see them anywhere in the results. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Search Typeahead with sub-agg search functionality for Issue and Product