Fix invalid paying_for_college test

[chosak]

This test in paying_for_college isn't actually testing anything. The call to

self.assertTrue(mock_requests.called_with, unicode_endpoint.encode("utf-8"))

is invalid because mock objects don't have a called_with method, they have assert_called_with.

The existing code is asserting True against something that is always truth, namely, the new mock returned by the call to the non-existent mock_requests.called_with method. The second argument is ignored as it's treated as the msg argument in assertTrue.

This PR fixes the test by correctly calling assert_called_with and also changing the mock to patch request.post, not request.get, as that's what's called by the notification code being tested.

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code follows the standards laid out in the CFPB development guidelines

[chosak]

I notice there are a bunch of other uses of mock.called_with in the cf.gov Python tests. I will fix those in a subsequent PR.

[wpears]

🔎

[higs4281]

Thank you.