Fix broken heading order on heroes page #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 1299 modified the content of the heroes page and added several examples with <h1> tags. This breaks Lighthouse accessibility checking, with then fails with "Heading elements are not in a sequentially-descending order". To fix this, this commit changes those <h1> tags to be <p class="h1">. This was also how the previous hero content was configured in f3085f2.
|
✔️ Thanks for the improvements! Browse a preview of your changes using the link below. 🔨 Explore the source changes: 9e507e8 🔍 Inspect the deploy log: https://app.netlify.com/sites/cfpb-design-system/deploys/61893cd22913e8000785cf6a 😎 Browse the preview: https://deploy-preview-1328--cfpb-design-system.netlify.app |
25 tasks
We use paragraph elements with an h1 class on the DS website to prevent lighthouse from reporting heading order errors. But we want developers to use h1 elements when adding heroes to cf.gov so we only use the p elements in the rendered code snippet section.
chosak
force-pushed
the
fix/heroes-heading-order
branch
from
a17a715 to
9e507e8
Compare
|
Thanks @contolini. Your commit missed a few of the examples so I've gone through and added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1299 modified the content of the heroes page and added several examples with
<h1>tags. This breaks Lighthouse accessibility checking, with then fails with "Heading elements are not in a sequentially-descending order". To fix this, this commit changes those<h1>tags to be<p class="h1">.This was also how the previous hero content was configured in f3085f2.
Edit: preview altered page at https://deploy-preview-1328--cfpb-design-system.netlify.app/design-system/patterns/heroes; this now scores 100 on Lighthouse.