Improve error graph for failed solve #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing a couple of edges that would help make it clearer why we were solving a constraint. In particular, this DepError was problematic: https://github.com/chainguard-dev/apko/blob/995ee5a40608591b2c4d2e7893abdffeca93f6ff/pkg/apk/apk/repo.go#L798 We were returning an error for the outer "pkg" and not including the context of the constraint within that package being solved or the failure of the selected package to solve its deps. Signed-off-by: Jon Johnson <[email protected]>
imjasonh
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a couple of edges that would help make it clearer why we were solving a constraint.
In particular, this DepError was problematic:
apko/pkg/apk/apk/repo.go
Line 798 in 995ee5a
We were returning an error for the outer "pkg" and not including the context of the constraint within that package being solved or the failure of the selected package to solve its deps.