fix(language-server): support escape hatched colors #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow escape hatch brackets when resolving a color token fix issue where regex with global flag retains state see: https://stackoverflow.com/a/1520853/684869 Fixes chakra-ui#38
🦋 Changeset detectedLatest commit: 3101b48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cgatian
commented
Feb 24, 2025
| @@ -45,14 +45,42 @@ test('CSS var', () => { | |||
| test('token reference with curly braces', () => { | |||
| const ctx = createContext() | |||
| expect(getTokenFromPropValue(ctx, 'border', '{colors.gray.300}')).toMatchInlineSnapshot(` | |||
There was a problem hiding this comment.
@astahmer this test was broken due to the backing regex maintaining state across invocation due to the g flag being used on the expression. Removed the /g flags from the expression.
cgatian
commented
Feb 24, 2025
|
|
||
| const removeEscapeHatch = (value: string) => { | ||
| if (ESCAPE_HATCHED.test(value)) { | ||
| return value.match(ESCAPE_HATCHED)?.[2] as string |
There was a problem hiding this comment.
If it matches, the second group should always be available
[#fff]
0: [#fff]
1: [
2: #fff
3: ]
astahmer
approved these changes
Feb 24, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow escape hatch brackets when resolving a color token
fix issue where regex with global flag retains state see: https://stackoverflow.com/a/1520853/684869
Closes #38
📝 Description
⛳️ Current behavior (updates)
Escaped hatched colors
color: [red]do not show inline hints🚀 New behavior
Escape hatched colors show color value preview
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information