[MOB-1756] Convention 파일 추가 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
이 쪽의 파일 버튼을 보는 게 훨씬 좋군요 |
vvvvvoin
reviewed
Aug 12, 2024
| 폴더 [[참고]](https://github.com/channel-io/bezier-compose/pull/16#issuecomment-2222027811) | ||
|
|
||
| - 모든 컴포넌트는 component 폴더 하위에 properties 패키지와 컴포넌트 파일로 생성합니다. | ||
| - bezier prefix를 제외하고 생성합니다. |
There was a problem hiding this comment.
bezier prefix를 제외하고 생성합니다 -> properties 패키지가 주어인가요?
CONVENTIONS.md
Outdated
Comment on lines
217
to
219
| enum class BezierButtonColor( | ||
| private val backgroundColor: @Composable () -> BezierColor, | ||
| ) |
There was a problem hiding this comment.
private는 서로 다른말하고 있는거 같아요?
Comment on lines
+182
to
+183
| // Don't | ||
| internal fun getBackgroundColor(color: BezierButtonColor, variant: BezierButtonVariant): BezierColor { |
There was a problem hiding this comment.
이것도 함수로 만들고 매개변수를 통해 표현한거 같네요.
|
|
||
| **Optional Modifier [[참고]](https://github.com/channel-io/bezier-compose/pull/42#discussion_r1699368350) [[참고2]](https://github.com/androidx/androidx/blob/androidx-main/compose/docs/compose-component-api-guidelines.md#modifier-parameter)** | ||
|
|
||
| - 제공하는 모든 디자인 컴포넌트에는 optional Modifier를 제공합니다. |
There was a problem hiding this comment.
진짜 진짜 잘 몰라서...
optional이 nullable로 해석할 수 있으니 다른 표현이 괜찮지 않나요?
There was a problem hiding this comment.
찾아보니까 코틀린에서는 default arguments라고 부르네요 🤔
https://kotlinlang.org/docs/functions.html#default-arguments
근데 Compose에서는 이거를 optional modifier라고 부르고 있고, (Is the first optional parameter)
optional parameter라는 말도 쓰이는 것 같아서 지금 표현이 괜찮을것 같아요
vvvvvoin
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convention을 추가합니다.
컨벤션으로 오인한 부분, 문장이 어색한 부분, 빠뜨린 부분 있는지 등 확인해주시면 좋을것 같습니다 🙇
https://www.easy-me.com/d 이 사이트에서 확인하면 확인해보기 좋습니다.