[MOB-2068] Switch 컴포넌트 구현 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodp5
commented
Sep 29, 2024
Comment on lines
+63
to
+68
| Box( | ||
| modifier = modifier | ||
| .padding(2.dp) | ||
| .clip(CircleShape) | ||
| .requiredSize(width = SwitchWidth, height = 28.dp) | ||
| .clickable( |
There was a problem hiding this comment.
외부 padding 대신에 실제 차지하는 너비를 넣고 싶었는데 SwitchWidth를 베이스로 계산해야하는 공식이 있어서 외부 padding을 넣었습니다 😢
(외부 padding을 사이즈에 포함시키면 계산식이 좀 더 난잡해져서..)
vvvvvoin
requested changes
Oct 4, 2024
bezier/src/main/java/io/channel/bezier/compose/component/switch/source/BezierSwitchControl.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
상태 변경기다릴때까지 잠시 disable되는건 이후에 작업되는걸까요?
There was a problem hiding this comment.
넵 이건 일단 없이 구현해뒀어요 근데 현재 기준 애니메이션 도중에는 다시 못바꾸긴 해요 (리뷰 받으려고 여기까지만 끊어서 작업했습니다)
There was a problem hiding this comment.
만약 하게된다면, 논의 후에 아예 다른 pr로 작업 할게요
bezier/src/main/java/io/channel/bezier/compose/component/switch/source/BezierSwitchControl.kt
Outdated
Show resolved
Hide resolved
bezier/src/main/java/io/channel/bezier/compose/component/switch/BezierSwitch.kt
Outdated
Show resolved
Hide resolved
bezier/src/main/java/io/channel/bezier/compose/component/switch/source/BezierSwitchControl.kt
Show resolved
Hide resolved
vvvvvoin
reviewed
Oct 7, 2024
bezier/src/main/java/io/channel/bezier/compose/component/switch/source/BezierSwitchControl.kt
Outdated
Show resolved
Hide resolved
vvvvvoin
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch 컴포넌트를 구현합니다.
코드 의도를 간략하게 남겨보면
Control은 좀 더 순수한 단위라고 생각되어서 UI를 표시하는 것 이외의 로직을 넣지 않으려 했습니다