Timer: fix duplicate ticks when stopping and starting fast #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stopping and starting a timer too fast, old ticks emitted before stopping are not dequeued correctly fast enough, and instead double or more "tick chains" are emitted. An int indicating to which cycle a tick belongs can solve this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stopping and starting a timer fast (under 1s), tick chains duplicate because the previous emitted tick hasn't been dequeued yet in the timer's update function. When this happens the timer advances faster than clock speed.
I've sketched this solution in case it's an adequate solution (I've not thoroughly tested it though). Ticks include a cycleId number that changes each time a model is started. If the timer is stopped/started too fast, it will be detected in the
Updatefunction than one of the ticks was sent before stopping the timer.