fix(stopwatch): timer was not accurate #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopwatch does not track correctly time since update process time can be longer that tick time update. This patch adds a start time with `sT` attribute to track time of stopwatch start. Also adapt view to have accuracy matching the tick interval. To have directly the raw duration value, use `Elapsed()` method. Issue: charmbracelet#237
fuhrmannb
force-pushed
the
stopwatch-precise-timer
branch
from
98f46b6 to
763f892
Compare
caarlos0
requested changes
Aug 13, 2024
| @@ -46,6 +46,7 @@ type ResetMsg struct { | |||
| // Model for the stopwatch component. | |||
| type Model struct { | |||
| d time.Duration | |||
| sT time.Time | |||
There was a problem hiding this comment.
i would name this start instead 🤔
Suggested change
| sT time.Time | |
| start time.Time |
| @@ -118,6 +119,12 @@ func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) { | |||
| if msg.ID != m.id { | |||
| return m, nil | |||
| } | |||
| if msg.running && !m.running { | |||
| m.sT = time.Now() | |||
There was a problem hiding this comment.
Suggested change
| m.sT = time.Now() | |
| m.start = time.Now() |
| m.sT = time.Now() | ||
| } | ||
| if !msg.running && m.running { | ||
| m.d += time.Since(m.sT) |
There was a problem hiding this comment.
Suggested change
| m.d += time.Since(m.sT) | |
| m.d += time.Since(m.start) |
| @@ -137,12 +143,15 @@ func (m Model) Update(msg tea.Msg) (Model, tea.Cmd) { | |||
|
|
|||
| // Elapsed returns the time elapsed. | |||
| func (m Model) Elapsed() time.Duration { | |||
| if m.running { | |||
| return m.d + time.Since(m.sT) | |||
There was a problem hiding this comment.
Suggested change
| return m.d + time.Since(m.sT) | |
| return m.d + time.Since(m.start) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopwatch does not track correctly time since update process time can be longer that tick time update.
This patch adds a start time with
sTattribute to track time of stopwatch start.Also adapt view to have accuracy matching the tick interval. To have directly the raw duration value, use
Elapsed()method.Issue: #237