-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(viewport)!: gutter column, soft wrap, search highlight #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carlos Alexandro Becker <[email protected]>
…ntal-scroll Feature/i236 viewport horizontal scroll
Signed-off-by: Carlos Alexandro Becker <[email protected]>
meowgorithm
reviewed
Jan 7, 2025
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Working on making it work in |
This was referenced Jan 28, 2025
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
moved this to v2 due to breaking changes: viewport now also allows for left/right/h/l, which needs to be handled in the caller if e.g. the user has a text input. |
windows tests are broken on v2-exp already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several somewhat related features to viewport.
Highlights
First, is highlights! This should allow users to add search features to their tea apps. You can see an example of this here.
CleanShot.2025-01-23.at.13.39.33.mp4
The highlights take into account visible characters and ANSI escape sequences, so users should be able to do something like:
And it should take care of everything.
Soft wrapping
Previously, users would have to soft wrap on their side, which is not as simple as it looks some times.
Having it here also helps with the left gutter feature, oops, I'm getting ahead of myself 🙈
Users can
m.SoftWrap = true
to enable this feature.You can see soft wrapping in action in the video above.
Left Gutter
This allows to add a fixed gutter to the left side of the viewport. You can use these to show line numbers, indicators, and more.
Users can set the gutter function with
m.LeftGutterFunc = <your func>
.Example with line numbers:
CleanShot.2025-01-23.at.13.40.51.mp4
Example with a selector:
CleanShot.2025-01-23.at.13.42.40.mp4
Other fixes