(v2) merge textarea API updates into v2-area #722
Merged
+354
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: additional bubbles Signed-off-by: Carlos Alexandro Becker <[email protected]> * Update README.md Co-authored-by: bashbunni <[email protected]> * Update README.md Co-authored-by: Christian Rocha <[email protected]> * Update README.md Co-authored-by: Christian Rocha <[email protected]> --------- Signed-off-by: Carlos Alexandro Becker <[email protected]> Co-authored-by: bashbunni <[email protected]> Co-authored-by: Christian Rocha <[email protected]>
* docs: update charm & friends blurb * docs: simplify messaging, link to instructions
If the viewport has borders, they are not currently taken into account when calculating the viewport max y offset, which might cause the last line to not be visible. This is easily reproducible in `gum pager`. Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]>
* feat(textarea): add CursorPosition method This returns the current cursor position accounting any soft-wrapped lines and multi-rune characters. * chore(textarea): redefine how real cursor properties are accessed (#714) --------- Co-authored-by: Christian Rocha <[email protected]>
This conforms to the new generic bubbletea API. See charmbracelet/bubbletea#1298
Co-authored-by: Ayman Bagabas <[email protected]>
Co-authored-by: Ayman Bagabas <[email protected]>
Set.CursorColumn sets the cursor column position. This change was made for clarity.
meowgorithm
requested review from
aymanbagabas,
caarlos0 and
bashbunni
as code owners
aymanbagabas
approved these changes
Feb 1, 2025
|
Tests are broken here, but the same ones are also broken in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings textarea API updates (and other stuff on
v2-exp) intov2-area.