Skip to content

Commit

Permalink
Remove notes about how we'd auto-truncate lines as we're doing that now
Browse files Browse the repository at this point in the history
  • Loading branch information
meowgorithm committed Feb 25, 2021
1 parent 3266c36 commit 65cb46c
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions renderer.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,6 @@ func (r *renderer) flush() {
return
}

// We have an opportunity here to limit the rendering to the terminal width
// and height, but this would mean a few things:
//
// 1) We'd need to maintain the terminal dimensions internally and listen
// for window size changes. [done]
//
// 2) We'd need to measure the width of lines, accounting for multi-cell
// rune widths, commonly found in Chinese, Japanese, Korean, emojis and so
// on. We'd use something like go-runewidth
// (http://github.com/mattn/go-runewidth).
//
// 3) We'd need to measure the width of lines excluding ANSI escape
// sequences and break lines in the right places accordingly.
//
// Because of the way this would complicate the renderer, this may not be
// the place to do that.

out := new(bytes.Buffer)

// Clear any lines we painted in the last render.
Expand Down

0 comments on commit 65cb46c

Please sign in to comment.