render: Make ffmpeg an optional dependency #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per commit 92db33b ffmpeg is not required anymore by VHS unless some rendering is enabled. For example we only use VHS as a testing tool and we rely on text output only, so having the whole ffmpeg installed isn't required. So do this check at rendering time instead of as a pre-requisite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per commit 92db33b ffmpeg is not required anymore by VHS unless some rendering is enabled.
For example we only use VHS as a testing tool and we rely on text output only, so having the whole ffmpeg installed isn't required.
So do this check at rendering time instead of as a pre-requisite