feat(cellbuf): implement style aware text wrapping #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
cellbuf/wrap
branch
2 times, most recently
from
7fab72c to
6ca6ac5
Compare
aymanbagabas
force-pushed
the
cellbuf/wrap
branch
from
6ca6ac5 to
25ea41a
Compare
raphamorim
reviewed
Feb 13, 2025
raphamorim
approved these changes
Feb 13, 2025
|
Great you add good test cases! |
This uses the same algorithm as in `ansi.Wrap` except that it also keeps track of the cursor style and link state and applies them to the wrapped text. We should use this instead of `ansi.Wrap` wherever styles and Hyperlinks are important.
aymanbagabas
force-pushed
the
cellbuf/wrap
branch
from
25ea41a to
421b202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same algorithm as in
ansi.Wrapexcept that it also keepstrack of the cursor style and link state and applies them to the wrapped
text.
We should use this instead of
ansi.Wrapwherever styles and Hyperlinksare important.