Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTIFY capability #73

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Add NOTIFY capability #73

merged 1 commit into from
Nov 12, 2023

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Nov 12, 2023

Delta Chat does not use it now,
but should: deltachat/deltachat-core-rust#4983
Having no capability will confuse whoever develops it.

Delta Chat does not use it now,
but should: <deltachat/deltachat-core-rust#4983>
Having no capability will confuse whoever develops it.
@link2xt
Copy link
Contributor Author

link2xt commented Nov 12, 2023

By the way, capability line it is not a hardcoded string in configure script, actual capability string is constructed dynamically at https://github.com/dovecot/core/blob/93a53a9d590f0220de28600f36a969cc38c3148b/src/imap/imap-client.c#L160-L204
Banner capability string (before login) is hardcoded, but it is the list of basic capabilities that cannot be disabled:
https://github.com/dovecot/core/blob/93a53a9d590f0220de28600f36a969cc38c3148b/configure.ac#L690-L699

E.g. NOTIFY is added only when mailbox_list_index is enabled.

On the other hand this will allow us to add X-CHATMAIL capability in the future.

@hpk42 hpk42 merged commit e400985 into main Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants