Add cookiesAccepted state + refactor set cookies #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bloom frontend
|
||||||||||||||||||||||||||||||
| Project |
Bloom frontend
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 08m 27s |
| Commit |
|
| Committer | Anna Hughes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
85
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves prep for issue #1207
What changes did you make and why did you make them?
Adds
cookiesAcceptedstate property touserSlice. This can now be used to determine whether to set cookies, as required in upcoming task #1207Also refactors existing use of cookies to ensure all cookies use the
Cookiespackage instead ofwindow.localStorage.setItem