-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaterBridge interaction #229
Open
cbouy
wants to merge
15
commits into
master
Choose a base branch
from
water_bridge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 94.44% 94.72% +0.27%
==========================================
Files 21 22 +1
Lines 1513 1650 +137
==========================================
+ Hits 1429 1563 +134
- Misses 84 87 +3 ☔ View full report in Codecov by Sentry. |
addition of run_bridged_analysis
adjusted to have the metadata under the WaterBridge key with addition of _ligand_water and _water_protein additions
added suggested adjustments
* Update fingerprint.py added code for 2nd order water bridges * refactor: move to separate class * fix: typing * feat: add implementation for any order * chore: fix CI warning * fix: stable order of water residues in metadata * tests: rearrange waterbridge tests * refactor: introduce base bridged class and interface * tests: test water bridge params and validation --------- Co-authored-by: Cédric Bouysset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds water-mediated interactions to ProLIF. Continuation of PR #225