Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaterBridge interaction #229

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

WaterBridge interaction #229

wants to merge 15 commits into from

Conversation

cbouy
Copy link
Member

@cbouy cbouy commented Nov 26, 2024

Adds water-mediated interactions to ProLIF. Continuation of PR #225

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 98.02632% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.72%. Comparing base (742203b) to head (711e037).

Files with missing lines Patch % Lines
prolif/fingerprint.py 96.00% 2 Missing ⚠️
prolif/interactions/base.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   94.44%   94.72%   +0.27%     
==========================================
  Files          21       22       +1     
  Lines        1513     1650     +137     
==========================================
+ Hits         1429     1563     +134     
- Misses         84       87       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Update fingerprint.py

added code for 2nd order water bridges

* refactor: move to separate class

* fix: typing

* feat: add implementation for any order

* chore: fix CI warning

* fix: stable order of water residues in metadata

* tests: rearrange waterbridge tests

* refactor: introduce base bridged class and interface

* tests: test water bridge params and validation

---------

Co-authored-by: Cédric Bouysset <[email protected]>
prolif/interactions/base.py Dismissed Show dismissed Hide dismissed
prolif/interactions/water_bridge.py Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants