fix: getValibotConstraint to work with nullish schema (#37)

* nullish schemas have no required constraint * fix formatting
chimame · Oct 6, 2024 · 49a78ca · 49a78ca
1 parent 3453ec9
commit 49a78ca
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/constraint.ts b/constraint.ts
@@ -120,6 +120,10 @@ export function getValibotConstraint<
       constraint.required = false;
       // @ts-expect-error
       updateConstraint(schema.wrapped, data, name);
+    } else if (schema.type === "nullish") {
+      constraint.required = false;
+      // @ts-expect-error
+      updateConstraint(schema.wrapped, data, name);
     } else if (schema.type === "number") {
       // @ts-expect-error
       const minValue = schema.pipe?.find(

diff --git a/tests/constraint.test.ts b/tests/constraint.test.ts
@@ -11,6 +11,7 @@ import {
   maxValue,
   minLength,
   minValue,
+  nullish,
   number,
   object,
   optional,
@@ -83,6 +84,7 @@ describe("constraint", () => {
           pipe(string(), minLength(3, "min")),
           optional(pipe(number(), maxValue(100, "max"))),
         ]),
+        nullishString: nullish(string()),
       }),
       check(() => false, "refine"),
     );
@@ -145,6 +147,9 @@ describe("constraint", () => {
         required: false,
         max: 100,
       },
+      nullishString: {
+        required: false,
+      },
     };
 
     expect(getValibotConstraint(schema)).toEqual(constraint);