Fix build script issues #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not being interpreted as a variable, but as a string instead
The script had several issues which didn't allow it to run successfully. Here's a summary of the changes: - At least on Fedora, curl -O causes the script to output the tarball to the current directory, not the location indicated, so I've removed that flag - The directory set for patch is invalid. Add a variable which gives an absolute location - patch will fail if it can't find a directory for a variant that isn't stoney. Ignore the result and continue - On stoney, zstd will detect file conflicts and hang when it comes to any of them. Detect the file extensions and run the respective decompression command for each archive type
With the revamp of the script, the firmware changed its location. Point back to it on the kernel config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trial and error this should basically fix most issues after the revamp of the build script.