Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-checked attribute to align toolbars in table properties. #17728

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Add aria-checked attribute to align toolbars in table properties. #17728

merged 2 commits into from
Jan 10, 2025

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jan 9, 2025 •
edited
Loading

Suggested merge commit message (convention)

Feature (table): Improve aria attributes in table and cell align toolbars. Closes #17722

Additional information

I added role role=radiogroup and role=radio to table properties radio buttons like this one:

image

It means that pressed state of button will be indicated in aria-checked attribute.

@Mati365 Mati365 requested review from niegowski and arkflpc January 9, 2025 10:48
@Mati365 Mati365 requested a review from arkflpc January 9, 2025 11:29
@Mati365 Mati365 merged commit 9333cc9 into master Jan 10, 2025
9 checks passed
@Mati365 Mati365 deleted the ck/17722 branch January 10, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkflpc arkflpc arkflpc approved these changes

@niegowski niegowski Awaiting requested review from niegowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons in table and cell properties panels are missing aria-pressed attribute
2 participants
@Mati365 @arkflpc