-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email integration package #17849
base: master-it84
Are you sure you want to change the base?
Email integration package #17849
Conversation
ef17f86
to
6dd2c46
Compare
@@ -26,6 +26,7 @@ | |||
"@ckeditor/ckeditor5-table": "44.1.0", | |||
"@ckeditor/ckeditor5-utils": "44.1.0", | |||
"@ckeditor/ckeditor5-widget": "44.1.0", | |||
"@ckeditor/ckeditor5-email": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remember to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick code scan.
packages/ckeditor5-html-support/src/integrations/emailintegration.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round. No tests checked yet.
Co-authored-by: Marta Motyczynska <[email protected]>
Co-authored-by: Marta Motyczynska <[email protected]>
Co-authored-by: Marta Motyczynska <[email protected]>
… make it stateless.
…ssor-fix Internal(full-page): Removed property from the HtmlPageDataProcessor to make it stateless.
…-from-head-using-fullpage-plugin-docs Docs(full-page): Extended guide to `Full page HTML` with a configuration section.
…f-full-page-html-plugin Docs(full-page): Fixed error code in `Full page HTML` feature.
…ayout Internal: Editor should warn about missing TableLayout plugin in email integration.
Docs: Add `TableLayout` plugin mention in email integration docs.
Suggested merge commit message (convention)
Feature (email): Initialize email integration package.
Additional Information
Epic branch, do not merge.
Commercial PR: https://github.com/cksource/ckeditor5-commercial/pull/7064