Add integration for fullscreen feature with revision history #17941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (fullscreen): Add integration with revision history.
Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.
Feature (ui): Add
MenuBarView#disable()
andMenuBarView#enable()
methods. They disable/enable all top-level menus in menu bar. Closes #17940.Internal (ui): Add a
toolbar
property to theEditorUIView
class for coherent access for all editor types.Internal (ui): Make
EditorUI#_initMenuBar()
method public and rename it accordingly to allow for runtime toolbar creation.Additional information
ck/fullscreen-revision-history
in the related repository (one of the used types needs to be exported).disable()
andenable()
methods instead as it will be simpler and more coherent with the rest of the component code.AbstractEditorHandler
class. It should be treated as a go-to class, not the one that only throws errors for unsupported editor types.RevisionHistoryMock
class in unit tests providing as much integration as I found useful. It's arbitrary and I'm open for suggestions.EditorUIView#toolbar
was introduced to make the editor types UIs more coherent and better accessible. Without it here we'd have to useas
keyword to narrow the editor types used inAbstractEditorHandler
.