feat(backend): organization_domain webhook event types #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 52cc866 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adds the types for Organization Domain webhook events
ijxy
force-pushed
the
feat/organization-domain-event-webhook-types
branch
from
c45d6d7 to
7adce55
Compare
NicolasLopes7
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks for your contribution @ijxy! The changes looks good to me
Awesome! What's the deal with all the failing CI integration tests? Is that an upstream issue or a problem related to this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the types for Organization Domain webhook events
Description
Fixes #4818
To align with the rest of the JSON resources in
@clerk/backend, I have copied theOrganizationDomainJSONandOrganizationDomainVerificationJSONtypes from@clerk/types.Worth mentioning that the JSON type has
affiliation_email_addressandverificationas nullable, whereas the webhook docs don't. I have assumed that the code is correct and kept the nullable fields.Note: The relationship between
@clerk/backendand@clerk/typesseems a bit strange in that all(?) the JSON resources appear to be defined identically in both independently. I assume that there is a reason for this so I have not refactored it.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change