Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rename user database pk #209

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

kiritowu
Copy link
Collaborator

@kiritowu kiritowu commented Feb 1, 2025

Rationale:
As discussed earlier, current database schema does not correctly reflect the data stored in the database. In fact, in practice, we have been using email to identify user, but the database recorded it as UserName. This PR is to address that problem.

Changes:

  • Apply supabase migration to rename column UserName -> email and email_address is username.
  • Updated Frontend and Backend to reflect to latest schema. A quick run-through of major feature shows the code is working as intended.

@kiritowu kiritowu self-assigned this Feb 1, 2025
@kiritowu kiritowu merged commit 2613dcc into feat/user-settings Feb 3, 2025
1 check passed
Copy link
Collaborator

@elliotwutingfeng elliotwutingfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiritowu kiritowu deleted the refactor/rename-user-database-pk branch February 4, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants