Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/notification UI selection #212

Merged
merged 14 commits into from
Feb 9, 2025

Conversation

kiritowu
Copy link
Collaborator

@kiritowu kiritowu commented Feb 5, 2025

Closes #203

Changes:

  • Supabase migration to create book_subscription table
  • Create backend APIs for CRUD operation on book_subscriptions table
  • Add frontend UI and form to subscribe to different library for a particular book
image image
desktop view (dialog) mobile view (drawer)

@kiritowu kiritowu self-assigned this Feb 5, 2025
@kiritowu
Copy link
Collaborator Author

kiritowu commented Feb 5, 2025

Should i remove status and condition columns from database since they are not useful given our current usecase of daily morning email, or should i keep them for future-proof use case 🤔
image

@elliotwutingfeng
Copy link
Collaborator

I think we can drop the excess columns, we're still in beta and don't know what users prefer yet.

@elliotwutingfeng
Copy link
Collaborator

A "select all" for the libraries would be good too.

@kiritowu kiritowu merged commit b065067 into feat/notification Feb 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants