Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition in decode-stream and add test #61

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

bo-tato
Copy link
Contributor

@bo-tato bo-tato commented Jan 30, 2023

adds race condition test from #53
and a fix by appending an empty vec to src at the beginning rather than an on-drained callback to write an empty vec

Copy link
Collaborator

@KingMob KingMob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's passing the tests consistently, I think you may have hit upon the solution. Wish I'd thought of using concat. Thanks!

test/gloss/test/io.clj Outdated Show resolved Hide resolved
@KingMob
Copy link
Collaborator

KingMob commented Feb 2, 2023

Fixes #60.

@KingMob KingMob merged commit 662ce60 into clj-commons:master Feb 2, 2023
@KingMob
Copy link
Collaborator

KingMob commented Feb 2, 2023

Hey @bo-tato , how do you want to be thanked in the changelog? If you give me your name, I'll put it in there, or if you prefer, I can just use "bo-tato".

@bo-tato
Copy link
Contributor Author

bo-tato commented Feb 2, 2023

cool, can just use bo-tato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants