Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Site] Set eslint in CI to use filter_mode: nofilter #19444

Open
wants to merge 2 commits into
base: production
Choose a base branch
from

Conversation

KianNH
Copy link
Contributor

@KianNH KianNH commented Jan 27, 2025

Summary

Set eslint in CI to use filter_mode: nofilter. This stops errors from getting past reviewdog which would later be caught by npx eslint . locally.

Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2025

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d9b3202
Status: ✅  Deploy successful!
Preview URL: https://4c4d6cd5.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://kian-pcx-15539.cloudflare-docs-7ou.pages.dev

View logs

@KianNH
Copy link
Contributor Author

KianNH commented Jan 27, 2025

Error is successfully picked up

image

@KianNH KianNH requested a review from a team as a code owner January 27, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants