Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example in getting started #752

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Dec 27, 2023

Randomly noticed when blindly copy-pasting example there is an extra ). Also added mf.dispose() to make example more complete.

Copy link

changeset-bot bot commented Dec 27, 2023

⚠️ No Changeset found

Latest commit: 3c90a75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for fixing this! ✅

@mrbbot mrbbot merged commit a904927 into cloudflare:master Jan 2, 2024
5 of 6 checks passed
@pi0 pi0 deleted the patch-1 branch January 2, 2024 11:36
@olljanat
Copy link

olljanat commented Feb 4, 2024

@pi0 do you happen to have more complete example how to get started with this?

I mean things like:

  1. Do I need create Worker project first and install to miniflare package to there?
  2. Which file that example should be put.
  3. Any other needed configuration files needed to get started.

I ended up to see just a lot of errors which does not make any sense.

EDIT: Found working example from your repository https://github.com/pi0/miniflare-reproduction
Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants