update nodejs and add compile cache #3430
Conversation
| @@ -28,6 +28,9 @@ js_binary( | |||
| ":types_lib", | |||
| ], | |||
| entry_point = "scripts/build-types.js", | |||
| env = { | |||
| "NODE_COMPILE_CACHE": "/tmp/workerd-types-compile-cache", | |||
There was a problem hiding this comment.
I mean... do we need this? This action is only used to generate types right?
There was a problem hiding this comment.
Not strictly needed, no, but results in a significant performance improvement when used correctly... that is to say, there's no reason not to use it unless something in our setup precludes it.
There was a problem hiding this comment.
So does it just needs to be any temp directory then? We could try to add it to the Actions-based CI cache located in ~/bazel-disk-cache but I'm unsure if it really matters based on how long type generation takes.
There was a problem hiding this comment.
It can be any temp directory, but something that can be preserved in remote cache as well would be really good.
Passing NODE_COMPILE_CACHE environment variable enables compile cache on node.js