Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase PBKDF2 iterations to OWASP recommended value #3541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leon338
Copy link

@Leon338 Leon338 commented Feb 13, 2025

This PR increases the PBKDF2 iterations to align with the OWASP recommended value for better security. The change is minimal and does not affect other parts of the codebase.

This change follows security best practices as recommended by OWASP. Let me know if any further modifications are needed.

@Leon338 Leon338 requested review from a team as code owners February 13, 2025 21:02
@Leon338 Leon338 requested review from dom96 and vickykont February 13, 2025 21:02
Copy link

github-actions bot commented Feb 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Leon338
Copy link
Author

Leon338 commented Feb 13, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 13, 2025
@Leon338
Copy link
Author

Leon338 commented Feb 13, 2025

I ran some benchmarks on Cloudflare Workers, and based on the cpuTimeMs observed in production, it should be possible to run PBKDF2 with 600,000 iterations in under 250ms on production. On average, this takes about 6× longer than running 100,000 iterations. Given these results, this implementation should not pose an issue for the live system.

Of course, this doesn’t work on Workers Free, but 100,000 iterations didn’t work there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants