Adds Pyodide version check to prevent incorrect bundle release #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/pyodide-ver-check
branch
2 times, most recently
from
31efac8 to
00c1e24
Compare
dom96
force-pushed
the
dominik/pyodide-ver-check
branch
2 times, most recently
from
2ed7c19 to
7d6f4af
Compare
dom96
force-pushed
the
dominik/pyodide-ver-check
branch
from
7d6f4af to
8f0a15c
Compare
|
Not going to push the rebuilt bundle because it changes jaeger tracing and I'd rather avoid having to create a EW PR to fix that. The important part is that the rebuilt bundle passes the other tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple check to ensure an incorrectly build version of the pyodide bundle cannot be released.