Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Router-worker loss of sentry + metrics on error #7906

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Jan 25, 2025

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 949b7b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 25, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-wrangler-7906

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7906/npm-package-wrangler-7906

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-wrangler-7906 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-workers-bindings-extension-7906 -O ./cloudflare-workers-bindings-extension.0.0.0-vab026c8d7.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vab026c8d7.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-create-cloudflare-7906 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-kv-asset-handler-7906

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-miniflare-7906

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-pages-shared-7906

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-unenv-preset-7906

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-vite-plugin-7906

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-vitest-pool-workers-7906

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-workers-editor-shared-7906

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-workers-shared-7906

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12992161366/npm-package-cloudflare-workflows-shared-7906

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/catch-errors-jaeger-router-worker branch 2 times, most recently from f25d3dd to 2c38e0c Compare January 25, 2025 04:27
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/catch-errors-jaeger-router-worker branch from 2c38e0c to 949b7b0 Compare January 27, 2025 15:16
@WillTaylorDev WillTaylorDev marked this pull request as ready for review January 27, 2025 15:19
@WillTaylorDev WillTaylorDev requested review from a team as code owners January 27, 2025 15:20
@WalshyDev WalshyDev merged commit f5eaf4b into main Jan 27, 2025
32 checks passed
@WalshyDev WalshyDev deleted the willtaylor/catch-errors-jaeger-router-worker branch January 27, 2025 15:57
@edmundhung edmundhung mentioned this pull request Jan 28, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants