Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload metafiles for Workers Assets #8255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Upload metafiles for Workers Assets #8255

wants to merge 3 commits into from

Conversation

GregBrimble
Copy link
Contributor

Fixes WC-3248

Uploads Workers Assets metafiles (_headers & _redirects) as part of creating a new Worker version.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Will be done in a later PR after wrangler dev support

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: a75582f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch
@cloudflare/workers-shared Patch
miniflare Patch
@cloudflare/vite-plugin Patch
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 26, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-wrangler-8255

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8255/npm-package-wrangler-8255

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-wrangler-8255 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-workers-bindings-extension-8255 -O ./cloudflare-workers-bindings-extension.0.0.0-v41730e828.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v41730e828.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-create-cloudflare-8255 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-kv-asset-handler-8255

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-miniflare-8255

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-pages-shared-8255

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-unenv-preset-8255

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-vite-plugin-8255

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-vitest-pool-workers-8255

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-workers-editor-shared-8255

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-workers-shared-8255

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13552981590/npm-package-cloudflare-workflows-shared-8255

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble force-pushed the metafiles branch 3 times, most recently from 17aeefc to 91d8841 Compare February 26, 2025 07:01
@GregBrimble GregBrimble force-pushed the metafiles branch 4 times, most recently from b5f8f7d to e073de0 Compare February 26, 2025 15:59
@GregBrimble GregBrimble marked this pull request as ready for review February 26, 2025 15:59
@GregBrimble GregBrimble requested review from a team as code owners February 26, 2025 15:59
@GregBrimble GregBrimble changed the title Upload metafiles Upload metafiles for Workers Assets Feb 26, 2025
@GregBrimble GregBrimble force-pushed the metafiles branch 2 times, most recently from 8a50578 to a7f06ae Compare February 26, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants