Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .prettierrc from templates generated by npm create cloudflare #8263

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

irvinebroque
Copy link
Contributor

@irvinebroque irvinebroque commented Feb 26, 2025

refs #6948

Removes .prettierrc from templates that npm create cloudflare generates.

Prettier is awesome, spaces are awesome, tabs are awesome — choose what you want to use, what is best for your project. Many people have their own preferences, their own .prettierrc, etc. — and this gets in the way of that when creating new projects.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: What to test here
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: What to document

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 34fa385

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-wrangler-8263

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8263/npm-package-wrangler-8263

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-wrangler-8263 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-workers-bindings-extension-8263 -O ./cloudflare-workers-bindings-extension.0.0.0-v1b0e5f2ae.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v1b0e5f2ae.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-create-cloudflare-8263 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-kv-asset-handler-8263

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-miniflare-8263

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-pages-shared-8263

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-unenv-preset-8263

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-vite-plugin-8263

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-vitest-pool-workers-8263

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-workers-editor-shared-8263

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-workers-shared-8263

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13534450021/npm-package-cloudflare-workflows-shared-8263

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@Cherry Cherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see Cloudflare lead the industry with accessible code style configurations by default, perhaps behind an option for if folks want it or not in c3's prompts, instead of removing this altogether.

For power users, they have their own styles and preferences, but for new users which is where I personally see most c3 usage, setting some great accessible defaults is an awesome thing. 🧡

@vicb
Copy link
Contributor

vicb commented Feb 26, 2025

-1 to remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants