Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Python print e2e test again. #8272

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dom96
Copy link
Contributor

@dom96 dom96 commented Feb 26, 2025

This was reverted in #8252. Recreating to figure out what went wrong.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests

Test Plan

Tested locally by running:

CLOUDFLARE_ACCOUNT_ID=8d783f274e1f82dc46744c297b015a2f CLOUDFLARE_API_TOKEN="foobar" WRANGLER="node --no-warnings $PWD/packages/wrangler/bin/wrangler.js" WRANGLER_IMPORT="$PWD/packages/wrangler/wrangler-dist/cli.js" pnpm --filter wrangler run test:e2e -- packages/wrangler/e2e/dev.test.ts

I removed some of the other tests in dev.test.ts, thankfully the above seems to run it without getting caught on other tests that are failing so it allowed me to verify these work locally.

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 98108ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dom96 dom96 force-pushed the dominik/print-python-e2e branch from 2c5fe93 to 717bfae Compare February 26, 2025 16:36
@dom96 dom96 force-pushed the dominik/print-python-e2e branch from 717bfae to 98108ee Compare February 26, 2025 17:17
@dom96
Copy link
Contributor Author

dom96 commented Feb 26, 2025

Looks like the print fix isn't in wrangler yet, that's one of the reasons for the failure.

@workers-devprod workers-devprod added the e2e Run wrangler e2e tests on a PR label Feb 26, 2025
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-wrangler-8272

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8272/npm-package-wrangler-8272

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-wrangler-8272 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-workers-bindings-extension-8272 -O ./cloudflare-workers-bindings-extension.0.0.0-vba55ef702.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vba55ef702.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-create-cloudflare-8272 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-kv-asset-handler-8272

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-miniflare-8272

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-pages-shared-8272

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-unenv-preset-8272

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-vite-plugin-8272

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-vitest-pool-workers-8272

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-workers-editor-shared-8272

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-workers-shared-8272

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13549608185/npm-package-cloudflare-workflows-shared-8272

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants