Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:attributes of jsonschema in Go tags should be separated by "=" instead of colons #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:attributes of jsonschema in Go tags should be separated by "=" instead of colons #39

wants to merge 1 commit into from
+65 −65

Conversation

WayKwin
Copy link

@WayKwin WayKwin commented Mar 9, 2025 •
edited
Loading

Base on this code snippet attributes of jsonschema in Go tags should be separated by "=" instead of colons

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WayKwin WayKwin changed the title <fix>:attributes of jsonschema in Go tags should be separated by "=" instead of colons fix:attributes of jsonschema in Go tags should be separated by "=" instead of colons Mar 9, 2025
@WayKwin
Update theme_park.go task.go
407b030 
Base on this (code snippet)[https://github.com/cloudwego/eino/blob/df93610a63a7d30d9cccddffe313d4ee967dccbf/components/tool/utils/create_options.go#L100], the attributes of jsonschema in Go tags should be separated by "=" instead of colons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shentongmartin shentongmartin shentongmartin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WayKwin @CLAassistant @shentongmartin