-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support hz sdk #1291
base: develop
Are you sure you want to change the base?
feat: support hz sdk #1291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1291 +/- ##
===========================================
+ Coverage 72.21% 72.22% +0.01%
===========================================
Files 138 138
Lines 16137 16137
===========================================
+ Hits 11653 11655 +2
+ Misses 3889 3887 -2
Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 353 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
350 | 1 | 2 | 0 |
Click to see the invalid file list
- cmd/hz/sdk/hertz_sdk.go
@@ -149,7 +150,7 @@ func (arg *Argument) UpdateByManifest(m *meta.Manifest) { | |||
|
|||
// checkPath sets the project path and verifies that the model、handler、router and client path is compliant | |||
func (arg *Argument) checkPath() error { | |||
dir, err := os.Getwd() | |||
dir, err := dir_utils.Getwd() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥改这个
|
||
"github.com/cloudwego/hertz/cmd/hz/meta" | ||
"github.com/cloudwego/hertz/cmd/hz/util" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26 行多空格
@@ -59,7 +59,7 @@ func RegFunc(funcName string, fn func(...interface{}) interface{}, force ...bool | |||
return nil | |||
} | |||
|
|||
func (p *Expr) parseFuncSign(funcName string, expr *string) (boolOpposite *bool, signOpposite *bool, args []ExprNode, found bool) { | |||
func (p *Expr) parseFuncSign(funcName string, expr *string) (boolOpposite, signOpposite *bool, args []ExprNode, found bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改这里干啥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面类似的修改都撤消吧
|
||
func ParseHertzCmd(cmd *exec.Cmd) (thriftgoParams, hertzParams []string, err error) { | ||
cmdArgs := cmd.Args | ||
// thriftgo -r -o kitex_gen -g go:xxx -p kitex=xxxx -p otherplugin xxx.thrift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉 kitex 相关的内容
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: support hz sdk
zh(optional): 支持 hz sdk 化
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: