-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add ut for hertz/pkg/common/adaptor #264
Conversation
Codecov ReportBase: 59.17% // Head: 59.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #264 +/- ##
===========================================
+ Coverage 59.17% 59.26% +0.08%
===========================================
Files 79 79
Lines 8150 8150
===========================================
+ Hits 4823 4830 +7
+ Misses 2972 2967 -5
+ Partials 355 353 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It is forbidden to add a test only for the purpose of coverage but without logical meaning. refer to issue description #257 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!lgtm
What type of PR is this?
test
Check the PR title.
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: add ut for
hertz/pkg/common/adaptor
, coverage increased from 76.6% to 92.3%zh(optional): 增加对
hertz/pkg/common/adaptor
的单测,覆盖率从76.6%提高到了92.3%Which issue(s) this PR fixes:
#257