Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ut for hertz/pkg/common/adaptor #264

Merged
merged 6 commits into from
Sep 22, 2022
Merged

test: add ut for hertz/pkg/common/adaptor #264

merged 6 commits into from
Sep 22, 2022

Conversation

L2ncE
Copy link
Contributor

@L2ncE L2ncE commented Sep 21, 2022

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: add ut for hertz/pkg/common/adaptor, coverage increased from 76.6% to 92.3%
zh(optional): 增加对hertz/pkg/common/adaptor的单测,覆盖率从76.6%提高到了92.3%

Which issue(s) this PR fixes:

#257

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 59.17% // Head: 59.26% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (2a71ba0) compared to base (ea2569a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
+ Coverage    59.17%   59.26%   +0.08%     
===========================================
  Files           79       79              
  Lines         8150     8150              
===========================================
+ Hits          4823     4830       +7     
+ Misses        2972     2967       -5     
+ Partials       355      353       -2     
Impacted Files Coverage Δ
pkg/common/adaptor/response.go 94.59% <0.00%> (+18.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou
Copy link
Member

li-jin-gou commented Sep 21, 2022

It is forbidden to add a test only for the purpose of coverage but without logical meaning.

refer to issue description #257

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!lgtm

@li-jin-gou li-jin-gou merged commit ac34fef into cloudwego:develop Sep 22, 2022
@L2ncE L2ncE deleted the unit_test branch September 22, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants