Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve hertz/pkg/protocol/uri ut coverage #276

Merged
merged 14 commits into from
Sep 30, 2022
Merged

test: improve hertz/pkg/protocol/uri ut coverage #276

merged 14 commits into from
Sep 30, 2022

Conversation

L2ncE
Copy link
Contributor

@L2ncE L2ncE commented Sep 27, 2022

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

提高对hertz/pkg/protocol/uri的单测覆盖率

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: hertz/pkg/protocol/uri ut coverage increased from 70.35% to 88.9%
zh(optional): hertz/pkg/protocol/uri的单测覆盖率从 70.35% 提升到了 88.9%

Which issue(s) this PR fixes:

#257

@welkeyever
Copy link
Member

lint没过哈,辛苦看看

@welkeyever
Copy link
Member

gofumpt -l -extra .可以看到有哪些文件lint没过

@L2ncE
Copy link
Contributor Author

L2ncE commented Sep 29, 2022

gofumpt -l -extra .可以看到有哪些文件lint没过

done

Duslia
Duslia previously approved these changes Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 60.92% // Head: 61.57% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (9f70789) compared to base (b8382cc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
+ Coverage    60.92%   61.57%   +0.65%     
===========================================
  Files           84       84              
  Lines         8287     8287              
===========================================
+ Hits          5049     5103      +54     
+ Misses        2882     2830      -52     
+ Partials       356      354       -2     
Impacted Files Coverage Δ
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️
pkg/protocol/uri.go 86.43% <0.00%> (+16.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

li-jin-gou
li-jin-gou previously approved these changes Sep 29, 2022
@L2ncE L2ncE dismissed stale reviews from li-jin-gou and Duslia via 9f70789 September 29, 2022 12:19
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@welkeyever welkeyever merged commit 202fe6a into cloudwego:develop Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants